-
-
Notifications
You must be signed in to change notification settings - Fork 18
Rename data provider to follow naming convention #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: samdark <47294+samdark@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR renames a data provider method to align with the project's established naming convention. The previous name decimalZerosProvider was inconsistent with the pattern used by all other data providers in the test file.
Key Changes:
- Renamed
decimalZerosProvider→dataTrimDecimalZerosto follow thedata{MethodName}pattern - Updated the
#[DataProvider]attribute reference to match the new method name
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The
decimalZerosProviderdata provider method was inconsistent with the test file's naming convention where all data providers follow the patterndata{MethodName}.Changes:
decimalZerosProvider→dataTrimDecimalZerosintests/NumericHelperTest.php#[DataProvider]attribute to reference the new method nameThis aligns with existing data providers:
dataNormalize,dataIsInteger,dataConvertHumanReadableSizeToBytes, etc.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.