Trim decimals #156
Open
Trim decimals #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
samdark
commented
Jan 8, 2026
samdark
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
There was a problem hiding this comment.
Pull request overview
This PR adds a new NumericHelper::trimDecimalZeros() method that removes trailing zeros from the decimal part of numeric strings. The implementation handles various edge cases including null values, empty strings, negative numbers, and numbers without decimal parts.
- Adds
trimDecimalZeros()static method to NumericHelper class - Includes comprehensive test coverage with 10 test cases
- Updates documentation comment style for existing method
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/NumericHelper.php | Adds the new trimDecimalZeros() method with documentation, also fixes hyphenation in existing docblock |
| tests/NumericHelperTest.php | Adds test data provider and test method for the new functionality |
| CHANGELOG.md | Documents the new feature in the 2.7.1 release notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
This was referenced Jan 8, 2026
Contributor
Co-authored-by: samdark <47294+samdark@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: samdark <47294+samdark@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
vjik
reviewed
Jan 9, 2026
Tigrov
reviewed
Jan 9, 2026
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
diff --git c/src/NumericHelper.php i/src/NumericHelper.php index c602ede..2506fde 100644 --- c/src/NumericHelper.php +++ i/src/NumericHelper.php @@ -16,9 +16,6 @@ use function is_numeric; use function is_scalar; use function preg_match; use function preg_replace; -use function rtrim; -use function str_contains; -use function str_ends_with; use function str_replace; use function substr; @@ -176,7 +173,7 @@ final class NumericHelper * containing a decimal part. * * @return string|null The input string with trailing decimal zeros (and a trailing decimal - * separator, if any) removed, or `null` if the input was `null`. + * separator, if any) removed, or `null` if the input was `null` or an empty string. */ public static function trimDecimalZeros(?string $value): ?string {
diff --git c/src/NumericHelper.php i/src/NumericHelper.php index 2506fde..d1c388b 100644 --- c/src/NumericHelper.php +++ i/src/NumericHelper.php @@ -186,16 +186,26 @@ final class NumericHelper return null; } - if (!str_contains($value, '.')) { - return $value; - } - /** @psalm-suppress PossiblyNullArgument */ - $value = rtrim($value, '0'); - - if (!str_ends_with($value, '.')) { + $decimalPosition = strpos($value, '.'); + if ($decimalPosition === false) { return $value; } - return substr($value, 0, -1); + $length = strlen($value); + $index = $length - 1; + + while ($index > $decimalPosition && $value[$index] === '0') { + $index--; + } + + if ($index === $length - 1) { + return $value; + } + + if ($index === $decimalPosition) { + return substr($value, 0, $decimalPosition); + } + + return substr($value, 0, $index + 1); } }
vjik
requested changes
Jan 13, 2026
| return $value; | ||
| } | ||
|
|
||
| return substr($value, 0, -1); |
Member
There was a problem hiding this comment.
Check on empty string, and return null when it is empty string.
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Seems, for string ".000" result will be empty string.
Member
There was a problem hiding this comment.
Should it be in some cases 0, instead of null for empty result?
Member
There was a problem hiding this comment.
Good question. I don't know.
empty string => "0" or null ?
string with spaces only => "0" or null ?
"." => "0" or null?
I think we should choose between two options:
null => null
empty string => null
string with spaces only => null
"." => null
".00" => null
null => null
empty string => "0"
string with spaces only => "0"
"." => "0"
".00" => "0"
Member
Author
There was a problem hiding this comment.
I think the following would be expected:
null => null
empty string => null
string with spaces only => null
"." => null
".00" => '0'
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.