feat(plsql): sync grammar with upstream antlr/grammars-v4 #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 51 lexer tokens and 20 parser rules from upstream for enhanced Oracle support while preserving all existing Bytebase customizations. New capabilities: - Oracle 21c+ annotations (ANNOTATIONS clause) - CREATE SCHEMA statement - DROP MATERIALIZED VIEW LOG statement - Compound triggers (COMPOUND TRIGGER) - MOVE PARTITION / RENAME PARTITION operations - SQL%BULK_ROWCOUNT / SQL%BULK_EXCEPTIONS expressions - Preprocessor directives ($IF, $ERROR, $ELSIF, etc.) - ACCESSIBLE BY clause for package visibility - PIPELINED USING clause - DEFAULT COLLATION clause Also fixes: - Sequence keywords for Oracle 19C+ (NOKEEP, NOSCALE, GLOBAL, etc.) - Extra semicolon in create_type.sql test file All 371 tests pass with no regressions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…port Adds 28 additional parser rules from upstream: C External Call Support: - c_external_parameter, c_property Analytic Views: - hierarchies_clause, filter_clause, filter_clauses - subav_clause, subav_factoring_clause - add_calc_meas_clause, add_calcs_clause - aggregate_clause Utility Rules: - parallel_instances_clause, overriding_procedure_spec - assignable_element, connection_qualifier, local_link_name - by_user_for_statistics_clause, unary_logical_operation - variable_or_collection, collection_expression - virtual_column_expression Partition Values: - index_partitioning_values_list, range_values_list SQL*Plus: - clear_command, start_command, sql_plus_command_no_semicolon Other: - expressions_, string_delimiter, system_actions All 371 tests pass. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Integrates the upstream rules into the main grammar so they are actually usable: - Add create_schema to unit_statement - Add drop_materialized_view_log to unit_statement - Add accessible_by_clause to create_package, create_function_body, create_procedure_body - Add annotations_clause to create_package, create_function_body, create_procedure_body - Add default_collation_clause to create_package, create_function_body, create_procedure_body - Add compound_trigger_block to trigger_body - Integrate pipelined_using_clause into create_function_body for polymorphic table functions (ROW/TABLE POLYMORPHIC) Test files added from upstream: - examples/create_function03.sql (polymorphic pipelined function) - examples/drop_materialized_view_log.sql All 373 tests pass. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move LEFT_CURLY_PAREN and RIGHT_CURLY_PAREN to be adjacent to LEFT_BRACKET/RIGHT_BRACKET and LEFT_PAREN/RIGHT_PAREN for easier navigation and consistency. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
vsai12
force-pushed
the
feat/plsql-grammar-sync-upstream
branch
from
ea71aee to
1f0aff8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New Capabilities
ANNOTATIONSclause)CREATE SCHEMAstatementDROP MATERIALIZED VIEW LOGstatementCOMPOUND TRIGGER)MOVE PARTITION/RENAME PARTITIONoperationsSQL%BULK_ROWCOUNT/SQL%BULK_EXCEPTIONSexpressions$IF,$ERROR,$ELSIF, etc.)ACCESSIBLE BYclause for package visibilityPIPELINED USINGclauseDEFAULT COLLATIONclauseNot Included (Future Work)
The following 63 upstream rules were not added due to conflicts or complexity:
These can be added incrementally as customer needs arise.
Test plan
make build- passesmake test- 371/371 tests pass🤖 Generated with Claude Code