fix(plsql): add missing tokens to regular_id rule #48
+1,746
−1,389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new tokens from the grammar sync to the regular_id rule so they can be used as identifiers: - ITEMS, BYTES, LINES, RECORDS, FIELD, MASK, NEWLINE_ - CHARSETFORM, CHARSETID, DURATION, ENABLED, MAXLEN - ERROR_CODE, ERROR_INDEX - EXTEND, NOEXTEND, NOSCALE, NOSHARD, SHARD, POLYMORPHIC These tokens were added to the lexer in the grammar sync but were not added to regular_id, causing them to be treated as reserved keywords that cannot be used as identifiers. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
regular_idrule so they can be used as identifiersProblem
These tokens were added to the lexer in the grammar sync (#47) but were not added to
regular_id, causing them to be treated as reserved keywords that cannot be used as identifiers.For example,
CREATE TABLE ITEMS (ID NUMBER PRIMARY KEY)fails to parse becauseITEMSis tokenized but not allowed as an identifier.Test plan
make testin plsql/)🤖 Generated with Claude Code