Skip to content

Conversation

@zmoon
Copy link
Owner

@zmoon zmoon commented Jan 17, 2026

No description provided.

zmoon added 8 commits January 17, 2026 08:52
in case add some template files or something later
in CI got:
ImportError: cannot import name 'escape' from 'html'
(/home/runner/work/PyABC2/PyABC2/pyabc2/abcjs/html/__init__.py)

which is used in Norbeck, but also by anywidget deps, it looks like in
the tb
@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.60%. Comparing base (57edde3) to head (0e68638).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files          13       13           
  Lines        1517     1517           
=======================================
  Hits         1420     1420           
  Misses         97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zmoon
Copy link
Owner Author

zmoon commented Jan 17, 2026

Specifying the tests' location fixes the error, which seems to have been related to test discover, but should also consider renaming the html module to something that doesn't shadow a built-in.

Edit: but now we're missing the doctests (looks like that's why the cov dropped slightly), so definitely need another solution.

@zmoon zmoon marked this pull request as ready for review January 17, 2026 15:47
@zmoon zmoon requested a review from Copilot January 17, 2026 15:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request reorganizes the abcjs-related modules into a more structured namespace under pyabc2.abcjs, and renames the optional extras to better reflect their purpose.

Changes:

  • Consolidates abcjs modules under pyabc2.abcjs.* namespace (widget, headless, html)
  • Renames package extras from widget/sheet to abcjs-widget/abcjs-headless for clarity
  • Updates all import statements, documentation, and examples to reflect the new structure
  • Updates abcjs documentation URLs from paulrosen.github.io to docs.abcjs.net

Reviewed changes

Copilot reviewed 11 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_html.py Updates import path to new location pyabc2.abcjs.html
tests/test_abcjs_headless.py Updates import path to new location pyabc2.abcjs.headless
pyproject.toml Renames extras to abcjs-widget and abcjs-headless
pyabc2/parse.py Updates widget import path and error message for new extra name
pyabc2/abcjs/widget/index.js New widget JavaScript implementation file
pyabc2/abcjs/widget/index.css New widget CSS stylesheet
pyabc2/abcjs/widget/init.py Widget module with updated docstring and import examples
pyabc2/abcjs/html/init.py Updates documentation URL to new domain
pyabc2/abcjs/headless/render.js New Node.js rendering implementation
pyabc2/abcjs/headless/package.json New Node.js package configuration
pyabc2/abcjs/headless/cli.cjs New CLI implementation for headless rendering
pyabc2/abcjs/headless/init.py Updates error message for new extra name and documentation URL
docs/examples/widget.ipynb Updates all import paths and module references
docs/api.rst Restructures API documentation with new module hierarchy
.readthedocs.yaml Updates extra dependencies for documentation build
.gitignore Updates path for test files in new location
.github/workflows/ci.yml Adds explicit tests/ directory to pytest command

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zmoon zmoon merged commit 55eaa92 into main Jan 19, 2026
9 checks passed
@zmoon zmoon deleted the abcjs branch January 19, 2026 05:43
zmoon added a commit that referenced this pull request Jan 19, 2026
thought about it in #91 but then forgot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants