Skip to content

Conversation

@birdcar
Copy link
Contributor

@birdcar birdcar commented Jan 13, 2026

Description

Context is in this PR comment, but ultimately this PR changes the release workflow so that it doesn't work with environments (yet).

Environment creation / trusted publisher setup will happen in a future PR.

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@birdcar birdcar requested a review from gjtorikian January 13, 2026 20:41
@birdcar birdcar self-assigned this Jan 13, 2026
@birdcar birdcar requested a review from a team as a code owner January 13, 2026 20:41
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 13, 2026

Greptile Summary

This PR removes the unused OIDC-based trusted publisher environment configuration from the GitHub Actions release workflow. The changes revert to using traditional TWINE_PASSWORD authentication for PyPI publishing. This is a temporary refactor as noted in the PR description, with plans to re-establish proper trusted publisher setup in a future PR. The workflow remains fully functional and the changes are backward compatible.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • This is a simple, low-risk change that removes unused workflow configuration. The YAML syntax is correct, the workflow remains functional, and the change is explicitly documented as temporary in the PR description. No custom rules apply to this change. The modification is backward compatible and doesn't introduce any security vulnerabilities or breaking changes.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/release.yml Removed unused OIDC/trusted publisher environment configuration from release workflow. The workflow now uses traditional TWINE_PASSWORD authentication instead of OpenID Connect. Change is backward compatible and intentionally temporary as noted in PR description.

Sequence Diagram

sequenceDiagram
    participant Developer
    participant GitHub
    participant PyPI
    
    Developer->>GitHub: Push Release
    GitHub->>GitHub: Trigger release.yml workflow
    GitHub->>GitHub: Checkout code
    GitHub->>GitHub: Install uv
    GitHub->>GitHub: Install dependencies
    GitHub->>GitHub: Run tests
    GitHub->>GitHub: Build distribution
    GitHub->>PyPI: Publish with TWINE_PASSWORD
    Note over GitHub,PyPI: Traditional auth (removed OIDC)
    PyPI-->>GitHub: Package uploaded
    GitHub-->>Developer: Release complete
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@birdcar birdcar force-pushed the birdcar/remove-release-environment-for-now branch from a424b19 to 5e75c00 Compare January 13, 2026 20:45
@birdcar
Copy link
Contributor Author

birdcar commented Jan 13, 2026

@greptileai

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@gjtorikian gjtorikian merged commit f9f4299 into main Jan 13, 2026
10 checks passed
@gjtorikian gjtorikian deleted the birdcar/remove-release-environment-for-now branch January 13, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants