-
Notifications
You must be signed in to change notification settings - Fork 25
Remove unused pypi environment for now #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Greptile SummaryThis PR removes the unused OIDC-based trusted publisher environment configuration from the GitHub Actions release workflow. The changes revert to using traditional TWINE_PASSWORD authentication for PyPI publishing. This is a temporary refactor as noted in the PR description, with plans to re-establish proper trusted publisher setup in a future PR. The workflow remains fully functional and the changes are backward compatible. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Developer
participant GitHub
participant PyPI
Developer->>GitHub: Push Release
GitHub->>GitHub: Trigger release.yml workflow
GitHub->>GitHub: Checkout code
GitHub->>GitHub: Install uv
GitHub->>GitHub: Install dependencies
GitHub->>GitHub: Run tests
GitHub->>GitHub: Build distribution
GitHub->>PyPI: Publish with TWINE_PASSWORD
Note over GitHub,PyPI: Traditional auth (removed OIDC)
PyPI-->>GitHub: Package uploaded
GitHub-->>Developer: Release complete
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
a424b19 to
5e75c00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
Description
Context is in this PR comment, but ultimately this PR changes the release workflow so that it doesn't work with environments (yet).
Environment creation / trusted publisher setup will happen in a future PR.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.