feat: support system info driven by pressure api #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-wasniowski
commented
Jun 24, 2025
k-wasniowski
commented
Jun 24, 2025
antsukanova
reviewed
Jun 25, 2025
k-wasniowski
requested review from
SomeBody16,
antsukanova,
chrisadubois,
edvujic and
oleksiijko
chrisadubois
approved these changes
Jun 25, 2025
antsukanova
reviewed
Jun 26, 2025
edvujic
approved these changes
Jun 26, 2025
SomeBody16
approved these changes
Jun 26, 2025
antsukanova
approved these changes
Jun 26, 2025
brycetham
reviewed
Jun 26, 2025
Collaborator
brycetham
left a comment
brycetham
left a comment
There was a problem hiding this comment.
Some small comments. Overall the API looks good :)
brycetham
approved these changes
Jun 27, 2025
Collaborator
brycetham
left a comment
brycetham
left a comment
There was a problem hiding this comment.
Approved, with a small comment that doesn't need to be addressed (just wanted to put my thoughts out there).
| * | ||
| * @returns True if the Compute Pressure API is supported, false otherwise. | ||
| */ | ||
| static isPressureObserverSupported(): boolean { |
Collaborator
There was a problem hiding this comment.
Just a thought I had... every time I look at this API, I wonder to myself how useful exposing it is. But I guess it doesn't hurt to keep it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.