Skip to content

Conversation

@Quinn-With-Two-Ns
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Jan 13, 2026

Update Graal reachability metadata to fix Nexus in time skipping test server. I also had to upgrade the format of the Graal configs to the new reachability-metadata.json. I tested by building the time skipping server as a native executable and running against Python CI.


Note

Modernizes native build config and verifies Nexus failure handling.

  • Migrate GraalVM native-image setup to new reachability-metadata.json and trim native-image.properties; enable agent metadata mergeWithExisting in Gradle
  • Add testNexusOperationHandlerTemporalFailure in NexusWorkflowTest using DefaultDataConverter and NexusUtil to validate retryable→non-retryable Nexus handler failures and resulting workflow history

Written by Cursor Bugbot for commit e46b1f2. This will update automatically on new commits. Configure here.

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner January 13, 2026 21:35
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a19af87674

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +2820 to +2823
{
"type": "io.temporal.testserver.functional.ChildLivesLongerThanParentTest",
"allDeclaredFields": true,
"methods": [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove test-only types from native image metadata

The new reachability metadata now lists io.temporal.testserver.functional.* test classes for reflection (e.g., ChildLivesLongerThanParentTest). These types live under temporal-test-server/src/test/java and are not present on the runtime classpath when building the temporal-test-server native image, so native-image will fail with a missing class error unless -H:+AllowIncompleteClasspath is enabled. The previous config files did not include test classes, so this regression breaks native builds in the default configuration.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant