cgosqlite: fix small leak in DisableFunction #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spotted while looking for other bugs. Updates tailscale/corp#31396
raggi
force-pushed
the
raggi/disable-func-free
branch
from
f67c710 to
20300c2
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes a memory leak in the DisableFunction method where a C string allocated via C.CString was not being freed after use.
- Added proper memory cleanup for the C string allocated from the function name parameter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrew-d
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while looking for other bugs.
Updates https://github.com/tailscale/corp/issues/31396