Global test refactoring #3472
Merged
Global test refactoring #3472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldergod
force-pushed
the
jwilson-bquenaudon.1118.actually_run_tests
branch
from
867abd5 to
0ecd14f
Compare
oldergod
force-pushed
the
jwilson-bquenaudon.1118.actually_run_tests
branch
from
0ecd14f to
3a016ea
Compare
oldergod
force-pushed
the
jwilson-bquenaudon.1118.actually_run_tests
branch
7 times, most recently
from
9c60d83 to
b761d9e
Compare
oldergod
force-pushed
the
jwilson-bquenaudon.1118.actually_run_tests
branch
from
b761d9e to
2ccc5e4
Compare
swankjesse
approved these changes
Jan 13, 2026
| val logger = object : WireLogger { | ||
| override fun artifactHandled(outputPath: Path, qualifiedName: String, targetName: String) { | ||
| logs.add("artifactHandled($qualifiedName, $targetName)") | ||
| @Test // TODO(Benoit) Delete? Nobody wanna maintain such a test |
Collaborator
There was a problem hiding this comment.
Don't delete it, it guarantees you don’t typo a parameter?
| val sources = arrayOf("service_kotlin_with_all_flags.proto") | ||
| compileToKotlin( | ||
| sources, | ||
| fun allTargetsAndAllOptions() { |
Collaborator
There was a problem hiding this comment.
Is this different from the other one?
Member
Author
There was a problem hiding this comment.
This also test the custom target!
which allows us to do in-memory tests not relying on gen-tests
oldergod
force-pushed
the
jwilson-bquenaudon.1118.actually_run_tests
branch
from
2ccc5e4 to
d4c501a
Compare
We removed a LOT of somewhat golden files and only consume them if some tests now. Proto generation to be used in other tests are now in wire-test-proto-generation, and wire-tests contains proto fixtures and testing modules.
oldergod
force-pushed
the
jwilson-bquenaudon.1118.actually_run_tests
branch
from
d4c501a to
0f334d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Organised in 3 commits: