Skip to content

Conversation

@alexgex
Copy link
Contributor

@alexgex alexgex commented Jan 12, 2026

This pull request introduces several important changes to the node CLI codebase, focusing on improving passive node handling, refactoring fair boot logic, updating container management, and cleaning up configuration paths. The main themes are: refactoring and relocating fair boot logic, improving passive node update and initialization, enhancing container filtering and log management, and removing unused configuration variables.

Fair Boot Logic Refactoring:

  • Moved and refactored the init_fair_boot and update_fair_boot functions from node_cli/operations/base.py to node_cli/operations/fair.py for better separation of concerns and maintainability. [1] [2] [3]
  • Updated imports in node_cli/operations/__init__.py to reflect the relocation of fair boot functions. [1] [2]

Passive Node Improvements:

  • Removed the unused unsafe_ok argument from passive node update logic in both CLI and core node modules, simplifying the interface. [1] [2]
  • Added host checks during passive node initialization and update, printing failed requirements if present, to improve reliability and user feedback. [1] [2]

Container Management Enhancements:

  • Improved container filtering in get_containers by using Docker name filters, and expanded passive compose services to include api and watchdog for more accurate service management. [1] [2]
  • Updated log backup and saving functions to accept a flexible tail parameter, supporting both integer and string types for log retrieval.

Configuration and Path Cleanup:

  • Removed the unused PASSIVE_COMPOSE_PATH constant and related references, and updated logic to use FAIR_COMPOSE_PATH for fair nodes, streamlining configuration management. [1] [2] [3]

Other Minor Improvements:

  • Added explicit ownership setting for Redis data directory during host preparation for better permission control. [1] [2]
  • Improved log creation by updating the default container name filter to match all relevant containers.

@alexgex alexgex linked an issue Jan 12, 2026 that may be closed by this pull request
badrogger
badrogger previously approved these changes Jan 12, 2026
dmytrotkk
dmytrotkk previously approved these changes Jan 12, 2026
@alexgex alexgex dismissed stale reviews from dmytrotkk and badrogger via 3b0e92d January 13, 2026 12:36
@alexgex alexgex merged commit 4f45d33 into develop Jan 14, 2026
2 checks passed
@alexgex alexgex deleted the merge-skale-active-and-passive-pipelines branch January 14, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge SKALE active and passive node pipelines

4 participants