-
Notifications
You must be signed in to change notification settings - Fork 7
Merge SKALE active and passive nodes pipelines #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badrogger
previously approved these changes
Jan 12, 2026
dmytrotkk
previously approved these changes
Jan 12, 2026
dmytrotkk
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important changes to the node CLI codebase, focusing on improving passive node handling, refactoring fair boot logic, updating container management, and cleaning up configuration paths. The main themes are: refactoring and relocating fair boot logic, improving passive node update and initialization, enhancing container filtering and log management, and removing unused configuration variables.
Fair Boot Logic Refactoring:
init_fair_bootandupdate_fair_bootfunctions fromnode_cli/operations/base.pytonode_cli/operations/fair.pyfor better separation of concerns and maintainability. [1] [2] [3]node_cli/operations/__init__.pyto reflect the relocation of fair boot functions. [1] [2]Passive Node Improvements:
unsafe_okargument from passive node update logic in both CLI and core node modules, simplifying the interface. [1] [2]Container Management Enhancements:
get_containersby using Docker name filters, and expanded passive compose services to includeapiandwatchdogfor more accurate service management. [1] [2]tailparameter, supporting both integer and string types for log retrieval.Configuration and Path Cleanup:
PASSIVE_COMPOSE_PATHconstant and related references, and updated logic to useFAIR_COMPOSE_PATHfor fair nodes, streamlining configuration management. [1] [2] [3]Other Minor Improvements: