fix: restore toolUseResult and user messages on session resume #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes three issues with session resume: 1. toolUseResult was not restored when loading sessions from JSONL, causing crashes in FileEditToolUpdatedMessage and OutputLine components 2. User text messages were never persisted to JSONL, causing the 2xESC undo menu to be empty after resume 3. Messages with mixed content (tool_result + text) were incorrectly filtered from the undo menu Changes: - Restore toolUseResult field in normalizeLoadedUser() - Persist user text messages in query() before the query loop - Extract filterUserTextMessagesForUndo() as a pure function - Fix filtering to check if ALL blocks are tool_result, not just first Fixes shareAI-lab#161 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
toolUseResultfield from JSONLTest plan
filterUserTextMessagesForUndofunctiontoolUseResultrestoration from session filesFixes #161
🤖 Generated with Claude Code