-
Notifications
You must be signed in to change notification settings - Fork 79
Start basic SCT support #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
842a112 to
e918319
Compare
src/sct.rs
Outdated
| #[allow(dead_code)] // pending sct verification | ||
| extensions: untrusted::Input<'a>, | ||
| #[allow(dead_code)] // pending sct verification | ||
| signature_algorithm: u16, | ||
| #[allow(dead_code)] // pending sct verification | ||
| signature: untrusted::Input<'a>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of verification needs to happen? Thoughts on a testing strategy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verification here would be a separate feature, taking a set of valid CT logs (their IDs, public keys, etc) and checking each SCT purported to come from a valid known log is correctly signed. Doing this verification is a future upki feature, mainly because tracking "valid CT logs" requires ongoing, current knowledge.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
==========================================
- Coverage 96.78% 96.78% -0.01%
==========================================
Files 19 20 +1
Lines 3797 3952 +155
==========================================
+ Hits 3675 3825 +150
- Misses 122 127 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Need to make sure to fuse the iterator if there's an unrecoverable error. (Personally not sure I mind |
What do you think about the opposite change -- Anyway, not married to this either way. I have one more addition to make on this PR then we can squash. |
Uh, do we allocate after the first pass, or |
Co-authored-by: Dirkjan Ochtman <dirkjan@ochtman.nl>
This (or precisely the hash of it) is used as an identifier to scope the serial number of a given end-entity cert.
I was thinking unwrap() -- I have dropped this commit just now. |
No description provided.