Replace custom release workflow with cargo-dist #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove custom release, upload-mac-universal-bin, and upload-linux-bin
jobs from ci.yml (these were manually building and uploading binaries)
- Add cargo-dist generated release.yml workflow that handles building,
signing, and uploading release artifacts automatically
- Update dotslash-config.json to match cargo-dist artifact naming:
- Use separate Mac Intel/ARM binaries instead of universal binary
- Update regex patterns to match pks-{arch}-{os} format
- Change format from tar.gz to tar.xz
- Add dist-workspace.toml with cargo-dist configuration:
- Targets: aarch64-apple-darwin, aarch64-unknown-linux-gnu,
x86_64-apple-darwin, x86_64-unknown-linux-gnu
- allow-dirty for custom dotslash job in release.yml
- Add [profile.dist] to Cargo.toml for optimized release builds
Resolves: pks-6yw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of release modernization: Replace custom release workflow with cargo-dist automation.
Changes
.github/workflows/ci.yml.github/workflows/release.yml.github/workflows/dotslash-config.jsondist-workspace.tomlCargo.tomlTest plan
Resolves: pks-6yw
Part of: PKS Release Process Modernization convoy