add initial-scale; move margin notes inline for narrow displays
#544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Resyntax analyzed 3 files in this pull request and found no issues.
shriram
reviewed
Jan 4, 2026
The `initial-scale` change move the specialization to 0.8 from the HTML renderer to `manual-doc-style`. This means that a `scribble/base` document will by default get a scale of 1.0, like it did before 2016, instead of 0.8. The margin-note change affects only the base CSS, and not manual style, which already does something similar. The implementation here is from @shriram. The change only moves right-margin notes and leaves left-margin notes alone, since there's always a left margin in the base Scribble style.
There was a problem hiding this comment.
Resyntax analyzed 3 files in this pull request and found no issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
initial-scalechange move the specialization to 0.8 from the HTML renderer tomanual-doc-style. This means that ascribble/basedocument will by default get a scale of 1.0, like it did before 2016, instead of 0.8.The margin-note change affects only the base CSS, and not manual style, which already does something similar. The implementation here is from @shriram. The change only moves right-margin notes and leaves left-margin notes alone, since there's always a left margin in the base Scribble style.