Cleaned up code #30
Merged
Cleaned up code #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR performs code cleanup and refactoring across localization files, URL creation utilities, and test widget components. The changes include restructuring types for better URL handling, fixing import paths, and adding proper module exports.
Changes:
- Enhanced URL creation utility to support query parameters and fragments with refined type definitions
- Fixed import paths across test widget components by correcting relative path depths
- Added proper index files and type definitions for test components
- Updated localization files with consistent line number formatting
Reviewed changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/src/common/localization/locales/pl.po.jinja | Added line numbers to source location comments |
| src/src/common/localization/locales/en.po.jinja | Added line numbers to source location comments |
| src/src/common/generic/lib/create-url/types.ts | Refactored to support both absolute and relative URLs with discriminated union types |
| src/src/common/generic/lib/create-url/main.ts | Enhanced to support query parameters and fragments, changed from trim to trimStart |
| src/src/client/test/components/test-widget/types.ts | New file defining TestWidgetInput type |
| src/src/client/test/components/test-widget/main.tsx | Fixed import paths by reducing unnecessary parent directory traversals |
| src/src/client/test/components/test-widget/index.ts | New barrel export file for the component |
| src/src/client/test/components/test-widget/components/test-form/types.ts | Fixed import path |
| src/src/client/test/components/test-widget/components/test-form/schemas.ts | New file defining Zod validation schemas |
| src/src/client/test/components/test-widget/components/test-form/main.tsx | Fixed import paths |
| src/src/client/test/components/test-widget/components/test-form/index.ts | New barrel export file |
| src/src/app/(root)/(main)/(home)/page.view.tsx | Updated import path to match new component structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.