-
Notifications
You must be signed in to change notification settings - Fork 870
chore: update api's for ppg_dev #7439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request updates the Postgres local development documentation to reflect API changes for the Prisma dev server. It renames Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
🍈 Lychee Link Check Report
📊 Results Overview
Errors per inputErrors in 200-orm/050-overview/100-introduction/250-should-you-use-prisma.mdx
|
Deploying docs with
|
| Latest commit: |
5582a85
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9dafe14b.docs-51g.pages.dev |
| Branch Preview URL: | https://dr-6846.docs-51g.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@content/250-postgres/300-database/550-local-development.mdx`:
- Around line 222-227: The example misstates the startPrismaDevServer "name"
option as required while the API table marks it optional with default 'default';
update the example to reflect that by making startLocalPrisma accept an optional
name and pass the default when omitted (adjust the startLocalPrisma signature
and the startPrismaDevServer call so name is optional and defaults to
'default'), referencing the startLocalPrisma function and the
startPrismaDevServer call so readers see the optionality matches the API table.
🧹 Nitpick comments (1)
content/250-postgres/300-database/550-local-development.mdx (1)
251-257: Consider a short note clarifying fixed defaults vs CLI ports.
Now that defaults are static (51213-51215), a short note can prevent confusion with the earlier CLI output that shows random ports.💡 Suggested doc tweak
Notes: - Allocate unique ports and `name` values when running tests concurrently. +- The CLI (`prisma dev`) may choose random ports, while `startPrismaDevServer` defaults to 51213-51215 unless overridden. - Use `server.database.connectionString` to connect with Postgres clients or ORMs.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
content/250-postgres/300-database/550-local-development.mdx
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-01-06T22:06:57.725Z
Learnt from: newclarityex
Repo: prisma/docs PR: 7425
File: content/200-orm/050-overview/500-databases/400-mysql.mdx:80-80
Timestamp: 2026-01-06T22:06:57.725Z
Learning: In Prisma docs, when showing examples of instantiating driver adapters with connection strings from environment variables, use the template literal pattern `const connectionString = `${process.env.DATABASE_URL}`` for consistency across all database adapter examples (PostgreSQL, MySQL/MariaDB, etc.).
Applied to files:
content/250-postgres/300-database/550-local-development.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Check internal links
- GitHub Check: Cloudflare Pages
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.