-
Notifications
You must be signed in to change notification settings - Fork 7
feat: React 18 and MUI migration with ESLint v8 upgrade and RTL test migration #2872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CarlaCostea
wants to merge
105
commits into
develop
Choose a base branch
from
feat/PD-5258
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: migrate ReactDOM.render to createRoot for React 18 compatibility
…into feat/PD-5258
…into feat/PD-5258 merge remote into current.
…into feat/PD-5258
…into feat/PD-5258
fix: fix math rendering issues after React, mui and drag upgrade for drag-in-the-blank
…into feat/PD-5258 pull remote into current.
…licate ids PD-5448
Add proper ESM package.json structure to enable loading in pie-esm-player: - Add "type": "module" for ESM package declaration - Add "sideEffects": false for better tree-shaking - Add "exports" field with three subpaths: - "." for main element (student view) - "./controller" for server-side controller - "./configure" for authoring interface - Maintain backward compatibility with CommonJS via dual exports Elements updated: categorize, charting, complex-rubric, ebsr, fraction-model, graphing, graphing-solution-set, hotspot, image-cloze-association, likert, match, match-list, math-inline, matrix, number-line, passage, placement-ordering, rubric, select-text All elements now expose ESM builds from esm/ directory while maintaining CommonJS builds in lib/ for backward compatibility. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This reverts commit d702a3c.
…#2871) - Update React to v18.2.0 and React DOM to v18.2.0 - Migrate tests from Enzyme to React Testing Library - Migrate from ReactDOM.render to createRoot API - Install and configure React Testing Library (@testing-library/react, jest-dom, dom) - Update jest.config.js: setupFilesAfterEnv, jsdom environment, transform ES modules - Upgrade ESLint from v5 to v8 with @babel/eslint-parser - Fix ESLint errors: hasOwnProperty usage, missing PropTypes, unused variables - Update Jest configuration
feat: clean up & removed snapshots from test logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the codebase to React 18 and Material-UI v7, upgrades ESLint to v8, and completes the migration from Enzyme to React Testing Library.
Major Changes
React & Material-UI Migration
@material-ui/coreto@mui/materialv7.3.4@material-ui/iconsto@mui/icons-materialv7.3.4@emotion/reactv11.14.0,@emotion/styledv11.14.1) required by MUI v7styledAPI and EmotionESLint Upgrade
@babel/eslint-parserfor Babel syntax supporteslint-plugin-reactto v7.34.0pretty-quick)ESLint Fixes
no-prototype-builtinserrors: Replaceobj.hasOwnProperty()withObject.prototype.hasOwnProperty.call()Test Infrastructure
renderWithProviders, PropTypes)