[RHCLOUD-43454] Updating data-view docs and adding compound options for Expandable, Sticky and Draggable #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakub007d
force-pushed
the
component
branch
2 times, most recently
from
22f15f0 to
cb0a2f4
Compare
Jakub007d
changed the title
| hasResizableColumns?: boolean; | ||
| /** Toggles expandable */ | ||
| isExpandable?: boolean; | ||
| /** Toogles sticky colums and headder */ |
Collaborator
There was a problem hiding this comment.
Small typos (Toogles, colums, headder)
| isExpandable?: boolean; | ||
| /** Toogles sticky colums and headder */ | ||
| isSticky?: boolean; | ||
| /** Toogles draggable rows */ |
| ```typescript | ||
| interface ExpandableContent { | ||
| /** The ID of the row containing the expandable cell (must match the id property in the row data) */ | ||
| row_id: number; |
Collaborator
There was a problem hiding this comment.
We are actually using camelCase in the code. I think this should be changed to rowId: number;
| /** The ID of the row containing the expandable cell (must match the id property in the row data) */ | ||
| row_id: number; | ||
| /** The column index (0-based) that should be expandable */ | ||
| column_id: number; |
Collaborator
There was a problem hiding this comment.
We are actually using camelCase in the code. I think this should be changed to columnId: number;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of task RHCLOUD-43454
Assisted-by: Claude Code