Patch for trending api for new api #176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fixes ongoing error for Google Trends API interactions also provides response with new POST api from google trends.
Issue: #175
I've added V2 function so it does not affect any existing ones but we might need to remove that, Also this is static for all categories, Need to get all the category api which returns list of rpc functions for category and we might need to update category.
Implementation is based on this PR: klept0/MS-Rewards-Farmer#268
I am using this in one my project, currently patch the package but will need more robust approach, I might work on v2 to update possibly all the apis.