Skip to content

Conversation

@merykitty
Copy link
Member

@merykitty merykitty commented Jan 11, 2026

Hi,

This is extracted from #28570

This PR fixes the return value of LoadStoreNode::adr_type and SCMemProj::adr_type. For the former, it is trivial that we can do what MemNode does. And for the latter, the implementation of ProjNode::adr_type is adequate.

Please kindly review, thanks a lot.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374969: Incorrect results of LoadStoreNode::adr_type and SCMemProj::adr_type (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29154/head:pull/29154
$ git checkout pull/29154

Update a local copy of the PR:
$ git checkout pull/29154
$ git pull https://git.openjdk.org/jdk.git pull/29154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29154

View PR using the GUI difftool:
$ git pr show -t 29154

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29154.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2026

👋 Welcome back qamai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 11, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jan 11, 2026
@openjdk
Copy link

openjdk bot commented Jan 11, 2026

@merykitty The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 11, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant