8374926: EnableX86ECoreOpts was not enabled on some hybrid CPU #29149
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnableX86ECoreOptshas been introduced in JDK-8319429, however model numbers which should be enabled are hard-coded, so the flag would not be enabled by default on some models like Arrow Lake.I ran a benchmark to check for effectiveness of
-XX:+EnableX86ECoreOptswith JDK 25.0.1 on Windows 11 25H2, I saw performance improvement a bit on Intel Core 5 Ultra 225U as following:Disabled (default)
Enabled
So I think it is better to enable this flag by default on all of hybrid CPUs.
To check what processor would be enabled E-core optimization, I made a commit to add comments for CPU models at first. I couldn't find out all of models (some models has not listed in SDM vol.4 so far), but most of models (excepts Sierra Forest) could be treated as hybrid CPU. Fortunately HotSpot identify hybrid flag from
CPUID, so we can leverage it for this purpose.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29149/head:pull/29149$ git checkout pull/29149Update a local copy of the PR:
$ git checkout pull/29149$ git pull https://git.openjdk.org/jdk.git pull/29149/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29149View PR using the GUI difftool:
$ git pr show -t 29149Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29149.diff
Using Webrev
Link to Webrev Comment