Skip to content

Conversation

@YaSuenag
Copy link
Member

@YaSuenag YaSuenag commented Jan 10, 2026

EnableX86ECoreOpts has been introduced in JDK-8319429, however model numbers which should be enabled are hard-coded, so the flag would not be enabled by default on some models like Arrow Lake.

I ran a benchmark to check for effectiveness of -XX:+EnableX86ECoreOpts with JDK 25.0.1 on Windows 11 25H2, I saw performance improvement a bit on Intel Core 5 Ultra 225U as following:

Disabled (default)

Benchmark Mode Cnt Score Error Units
RandMinVal.getMax thrpt 3 9707774.405 ± 27082629.015 ops/s
RandMinVal.getMin thrpt 3 7510319.839 ± 10923547.382 ops/s

Enabled

Benchmark Mode Cnt Score Error Units
RandMinVal.getMax thrpt 3 10127809.127 ± 45404142.338 ops/s
RandMinVal.getMin thrpt 3 8467677.056 ± 1211998.200 ops/s

So I think it is better to enable this flag by default on all of hybrid CPUs.

To check what processor would be enabled E-core optimization, I made a commit to add comments for CPU models at first. I couldn't find out all of models (some models has not listed in SDM vol.4 so far), but most of models (excepts Sierra Forest) could be treated as hybrid CPU. Fortunately HotSpot identify hybrid flag from CPUID, so we can leverage it for this purpose.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374926: EnableX86ECoreOpts was not enabled on some hybrid CPU (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29149/head:pull/29149
$ git checkout pull/29149

Update a local copy of the PR:
$ git checkout pull/29149
$ git pull https://git.openjdk.org/jdk.git pull/29149/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29149

View PR using the GUI difftool:
$ git pr show -t 29149

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29149.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2026

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 10, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 10, 2026
@openjdk
Copy link

openjdk bot commented Jan 10, 2026

@YaSuenag The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 10, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant