-
Notifications
You must be signed in to change notification settings - Fork 26
feat(provider): add aws-ssm provider
#331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @petertriho, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the OpenFeature Python SDK by adding a new provider for AWS Systems Manager Parameter Store. This integration enables developers to leverage AWS SSM as a backend for managing feature flags, benefiting from its secure and centralized parameter management capabilities. The new provider is designed for flexibility, offering both synchronous and asynchronous operations, along with configurable caching mechanisms to ensure efficient flag retrieval. It also includes comprehensive support for various flag data types and handles the mapping of flag keys to SSM parameter names, making it a robust solution for feature flag management in AWS environments. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new provider for AWS Systems Manager (SSM) Parameter Store. The implementation is well-structured, separating concerns into a service layer for AWS interaction, parsers for type conversion, and the provider itself. The caching implementation is flexible, supporting both LRU and TTL strategies, and can be disabled. The provider supports both synchronous and asynchronous operations. The accompanying documentation is thorough, and the test coverage is excellent, including unit, integration, and async tests.
I have a few suggestions to further improve the code's maintainability and clarity by removing some redundant validation logic, improving type hints, and clarifying a documentation example. Overall, this is a high-quality contribution.
providers/openfeature-provider-aws-ssm/src/openfeature/contrib/provider/awsssm/provider.py
Outdated
Show resolved
Hide resolved
providers/openfeature-provider-aws-ssm/src/openfeature/contrib/provider/awsssm/ssm_service.py
Outdated
Show resolved
Hide resolved
Had to relax `types-requests` versions due to resolution issue with boto3 Signed-off-by: Peter Tri Ho <mail@petertriho.com>
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new aws-ssm provider for the OpenFeature Python SDK, a valuable addition for users leveraging AWS Parameter Store for feature flagging. The implementation is robust, featuring both synchronous and asynchronous support, configurable caching (LRU and TTL), and clear separation of concerns between the service layer, parsers, and the provider itself. The error handling is particularly well-done, mapping specific AWS errors to OpenFeature exceptions. The accompanying test suite is comprehensive, covering unit, integration, and caching scenarios, which provides high confidence in the provider's correctness. I've included a couple of minor suggestions to improve configuration file clarity and documentation. Overall, this is an excellent contribution.
This PR
Notes
types-requestsversions due to resolution issue with boto3