Skip to content

Conversation

@gurgunday
Copy link
Member

As said by the person who put the todo in the first place, it has been redundant for a while now

We have kWeakHandler: this now

PR removes it to prevent confusion

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (637bda0) to head (932b31c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #60595   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         704      704           
  Lines      208883   208881    -2     
  Branches    40334    40322   -12     
=======================================
+ Hits       184890   184891    +1     
+ Misses      15977    15973    -4     
- Partials     8016     8017    +1     
Files with missing lines Coverage Δ
lib/internal/event_target.js 99.16% <ø> (-0.01%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anonrig anonrig requested a review from benjamingr November 6, 2025 02:50
@gurgunday gurgunday added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 19, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2026
@nodejs-github-bot
Copy link
Collaborator

@gurgunday gurgunday added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 19, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2026
@nodejs-github-bot nodejs-github-bot merged commit 5f7c3a6 into nodejs:main Jan 19, 2026
74 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5f7c3a6

@gurgunday gurgunday deleted the todo-done branch January 19, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants