Skip to content

fix(gc): (re)implement cache_chunk_gc_ttl #57504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
solracsf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(gc): (re)implement cache_chunk_gc_ttl #57504

solracsf wants to merge 1 commit into from
+8 −7

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Jan 12, 2026 •
edited
Loading

Summary

Maybe I've read the code wrongly, so correct me if I'm wrong, but this configurable value was never implemented? 🤔

server/config/config.sample.php

Lines 1866 to 1874 in ac3d09d

/**
* TTL of chunks located in the cache folder before they're removed by
* garbage collection (in seconds). Increase this value if users have
* issues uploading very large files via the Nextcloud Client as upload isn't
* completed within one day.
*
* Defaults to ``60*60*24`` (1 day)
*/
'cache_chunk_gc_ttl' => 60 * 60 * 24,

Checklist

@solracsf solracsf added this to the Nextcloud 33 milestone Jan 12, 2026
@solracsf solracsf requested a review from a team as a code owner January 12, 2026 23:02
@solracsf solracsf added 3. to review Waiting for reviews feature: files labels Jan 12, 2026
@solracsf solracsf requested review from a team, ArtificialOwl, blizzz, come-nc, icewind1991, nfebe, provokateurin and sorbaugh and removed request for a team January 12, 2026 23:02
provokateurin
provokateurin requested changes Jan 13, 2026
View reviewed changes
@solracsf
fix(gc): Implement cache_chunk_gc_ttl
df018cf 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf force-pushed the implementCacheChunkGcTtl branch from 3b6a0ee to df018cf Compare January 13, 2026 08:00
@solracsf solracsf changed the title fix(gc): Implement cache_chunk_gc_ttl fix(gc): (re)implement cache_chunk_gc_ttl Jan 13, 2026
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@provokateurin provokateurin provokateurin approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc

@blizzz blizzz Awaiting requested review from blizzz

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: files

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

3 participants

@solracsf @provokateurin