Skip to content

Conversation

@grnd-alt
Copy link
Member

@grnd-alt grnd-alt commented Jan 7, 2026

Not validating the hex values in php resulted in the possibility to set any string as a color value for labels.
not parseable color strings broke the ui of labels alltogether.

This PR validates if the color is valid hex in the backend.

In the frontend the text color of the tag is set depending of the color of the tag to black or white. In this code path the color is now also validated to repair boards where there is already a tag with an invalid color.

@grnd-alt grnd-alt force-pushed the fix/display-labels-with-invalid-colors branch 2 times, most recently from b64b7b6 to 959ee40 Compare January 7, 2026 16:06
@grnd-alt grnd-alt requested a review from juliusknorr January 7, 2026 16:06
@grnd-alt grnd-alt force-pushed the fix/display-labels-with-invalid-colors branch from 959ee40 to 65214bd Compare January 13, 2026 07:07
Signed-off-by: grnd-alt <git@belakkaf.net>
Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt grnd-alt force-pushed the fix/display-labels-with-invalid-colors branch from 4806c28 to b88498e Compare January 14, 2026 12:51
@juliusknorr
Copy link
Member

Needs backports, right?

@grnd-alt grnd-alt self-assigned this Jan 15, 2026
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jan 15, 2026
@grnd-alt grnd-alt moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Office team Jan 15, 2026
@grnd-alt grnd-alt moved this from 👀 In review to 🏗️ In progress in 📝 Office team Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

3 participants