[main] Fix: Keep 'done' status when updating archived card

[theoholl]

• Resolves: The card completion mark is reset if changes were made to the completed card #7294
• Target version: main

Summary

The update method of the CardController now handles the optional (and nullable) done parameter. When a card is marked as done, and the card updated, the 'done' status is not cleared anymore.

Screencast.Fix.mp4

[grnd-alt]

this change is correct in my view and approved as a fix.
But the behavior of cardService is very weird here.
The OptionalNullableValue doc states that done == null means the value has not been set and should not be updated, and done->getValue() == null means the value has been set and should be updated to be null.

Now the actual CardService behavior is to always just set the value though (as seen here: https://github.com/nextcloud/deck/blob/main/lib/Service/CardService.php#L297).
Which means when done is not included in the request it will be set to null. Which currently is not a problem, as we always seem to send it but is still very unexpected behavior in my eyes.
This change was done for the android app a while ago in this PR: #5491
But I don't really know why.
Maybe @stefan-niedermann could elaborate why this was required exactly, and if we can make done behave like all the other optional params to that function (ignore when null)

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)