Omit icons from responses when empty or nil
#212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `icons` parameter was always included in responses (as an empty array) even when not configured. This differs from the response representation in MCP Ruby SDK 0.4.0. Since `icons` is optional, it should be omitted from responses when unused to reduce unnecessary context window usage. https://modelcontextprotocol.io/specification/2025-11-25/schema#implementation This fix applies to `Tool#to_h`, `Prompt#to_h`, `Resource#to_h`, `ResourceTemplate#to_h`, and `Server#server_info`. It doesn't seem critical, but if there are no other issues, it would be good to cut 0.5.1 bugfix release soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Previously, the
iconsparameter was always included in responses (as an empty array) even when not configured. This differs from the response representation in MCP Ruby SDK 0.4.0.Since
iconsis optional, it should be omitted from responses when unused to reduce unnecessary context window usage.https://modelcontextprotocol.io/specification/2025-11-25/schema#implementation
This fix applies to
Tool#to_h,Prompt#to_h,Resource#to_h,ResourceTemplate#to_h, andServer#server_info.It doesn't seem critical, but if there are no other issues, it would be good to cut 0.5.1 bugfix release soon.
How Has This Been Tested?
New tests have been added and Existing tests have been updated.
Breaking Changes
None.
Types of changes
Checklist