Skip to content

[js/node] fix incorrect output name mapping #26939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fs-eire wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

[js/node] fix incorrect output name mapping #26939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/node/src/inference_session_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@
Napi::Object result = Napi::Object::New(env);

for (size_t i = 0; i < outputIndex; i++) {
result.Set(outputNames_[i], OrtValueToNapiValue(env, std::move(outputValues[i])));
result.Set(outputNames_cstr[i], OrtValueToNapiValue(env, std::move(outputValues[i])));
}
return scope.Escape(result);
} else {
Expand Down Expand Up @@ -244,7 +244,7 @@

Napi::Object result = Napi::Object::New(env);
for (size_t i = 0; i < outputIndex; i++) {
result.Set(outputNames_[i], OrtValueToNapiValue(env, std::move(outputs[i])));
result.Set(outputNames_cstr[i], OrtValueToNapiValue(env, std::move(outputs[i])));

Check warning on line 247 in js/node/src/inference_session_wrap.cc

View workflow job for this annotation

GitHub Actions / Optional Lint C++ 

[cpplint] reported by reviewdog 🐶
 Add #include <utility> for move  [build/include_what_you_use] [4]

Raw Output:
js/node/src/inference_session_wrap.cc:247:  Add #include <utility> for move  [build/include_what_you_use] [4]
}
return scope.Escape(result);
}
Expand Down
Loading