[WIP] Capture memory dumps on STL-ASan-CI test failures #6004
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run STL-ASan-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
This will not work for a Draft PR, not even with your spell |
StephanTLavavej
added
infrastructure
Member
Member
|
To investigate this while reducing cost, I recommend (1) temporarily altering the test suite to run a single shard with a single test, (2) damaging that test so it will crash, (3) working on your changes to capture a dump as an artifact. That way, you can skip the massive expense of full test runs, and feel less bad about using the CI for development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #4324
Context:
The STL-ASan-CI pipeline has been flaky in x86 for a long time now. We've made some progress, such as identifying that the issue may be related to a
nullptrde-reference, and that it seemingly occurs during program shutdown, but we have yet to root cause it.This PR aims to make a dent in root causing the problem by opting in to capturing memory dumps when a program fast-fails.
The next step is to kick off the pipeline a few times internally, and confirm this is working / producing dumps (a log should be emitted). Then we'll want to move those dumps to the pipeline attachments area, so they can be further analyzed.