-
Notifications
You must be signed in to change notification settings - Fork 1.6k
<flat_meow>: Add tests for all flat_map constructors, deduction guides and then some
#6000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vmichal
wants to merge
30
commits into
microsoft:feature/flat_map
Choose a base branch
from
vmichal:test-flat-meow
base: feature/flat_map
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,379
−267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cluding default args).
…ion-count-checking helper.
…st and Range&&, including allocator ctors.
…r test to test deduction guides.
<flat_meow>: Add tests for all flat_map constructors, deduction guides and then some<flat_meow>: Add tests for all flat_map constructors, deduction guides and then some
<flat_meow>: Add tests for all flat_map constructors, deduction guides and then some<flat_meow>: Add tests for all flat_map constructors, deduction guides and then some
This comment was marked as resolved.
This comment was marked as resolved.
… does not satisfy strict_weak_order
…onvert their argument to key_type
… have printable elements.
…erence and value_type
…lat_set::const_reference
…ype as flat_set::const_reference" This reverts commit c402040.
… case for flat_set).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed functionality:
flat_map::erase(OtherKey&&)whenOtherKeyis notkey_type.Tests:
flat_meow::insert,emplace_hintand similar functions accepting hint correctly handle correct hint (insertion takes place as close as possible to given hint)flat_map_STL_ASSERTs in both<flat_map>and<flat_set>- unsorted/duplicate elements in ranges and size mismatch of key and mapped container.<flat_meow>: Don't do extra work incount(),contains(), andequal_range()#5994, see discussion in<flat_map>:count(),contains(), andequal_range()are doing too much work #5992 ).Progress towards https://discord.com/channels/737189251069771789/1120873380615295027/1450952672982204468