Skip to content

[Bug]: Shopify Connector: Creating a Sales Credit Memo from Shopify Refund mixes Amounts with Presentment Amounts #6139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
natidrb wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Bug]: Shopify Connector: Creating a Sales Credit Memo from Shopify Refund mixes Amounts with Presentment Amounts #6139

natidrb wants to merge 2 commits into from
+7 −1

Conversation

@natidrb
Copy link

@natidrb natidrb commented Jan 13, 2026 •
edited by github-actions bot
Loading

Fixes #6138

@natidrb natidrb requested a review from a team as a code owner January 13, 2026 17:07
@github-actions github-actions bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork labels Jan 13, 2026
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Jan 14, 2026
onbuyuka
onbuyuka previously approved these changes Jan 19, 2026
View reviewed changes
@onbuyuka onbuyuka added the Linked Issue is linked to a Azure Boards work item label Jan 19, 2026
@github-actions github-actions bot added this to the Version 28.0 milestone Jan 19, 2026
JesperSchulz
JesperSchulz previously approved these changes Jan 19, 2026
View reviewed changes
@onbuyuka
Copy link
Contributor

onbuyuka commented Jan 19, 2026

@natidrb this PR does not compile:

  Compilation started for project 'Shopify Connector' containing '632' files at '12:47:35.784'.
  
  Error: AL0118 The name '"Presentment Disc. Total Amt."' does not exist in the current context.

You are missing ReturnLine."Presentment Disc. Total Amt.". It would be nice if you could build and test your changes before you create PRs in the future.

@natidrb @onbuyuka
Update src/Apps/W1/Shopify/App/src/Order Return Refund Processing/Cod…
750332c 
…eunits/ShpfyCreateSalesDocRefund.Codeunit.al

Co-authored-by: Onat Buyukakkus <55088871+onbuyuka@users.noreply.github.com>
@natidrb natidrb dismissed stale reviews from JesperSchulz and onbuyuka via 750332c January 19, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JesperSchulz JesperSchulz JesperSchulz approved these changes

@onbuyuka onbuyuka onbuyuka approved these changes

Assignees

No one assigned

Labels

AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item

Projects

None yet

Milestone

Version 28.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Shopify Connector: Creating a Sales Credit Memo from Shopify Refund mixes Amounts with Presentment Amounts

3 participants

@natidrb @onbuyuka @JesperSchulz