-
Notifications
You must be signed in to change notification settings - Fork 24
Support auto-merge for Cask updates #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
.github/workflows/casks.yml
Outdated
| # Status check that is required in branch protection rules. | ||
| cask-status: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github/workflows/casks.yml
Outdated
| changed-casks: | ||
| name: Get changed casks | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| matrix: ${{ steps.changed-files.outputs.all_changed_files }} | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - name: Get changed files | ||
| id: changed-files | ||
| uses: tj-actions/changed-files@v47 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/mdogan/homebrew-zulu/actions/runs/18127831550
The action tj-actions/changed-files@v47 is not allowed in mdogan/homebrew-zulu because all actions must be from a repository owned by mdogan, created by GitHub, verified in the GitHub Marketplace, or match one of the patterns: peter-evans/create-pull-request@, tibdex/github-app-token@.
This can't work for now due to GitHub's limitations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can view the results in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read some problems about tj-actions/changed-files action, that's why I'm hesitating to allow it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works well, from my observations. And I noticed there are other solutions like the Homebrew official used, but they are too complex!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the auto-merge in Goooler#93.
FYI, I added a related PR to my repo. Goooler/homebrew-repo#61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if we want to land something like #50, this is useful.
|
This should be useful for the PRs like #94. |
fbf82be to
4e37cab
Compare
8ba4394 to
4495e9c
Compare

Refs
One more step on #81.