Skip to content

Conversation

Comment on lines 60 to 61
# Status check that is required in branch protection rules.
cask-status:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After enabling this in the repo's branch rules, the auto-merge step could work well.

image

Comment on lines 12 to 19
changed-casks:
name: Get changed casks
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.changed-files.outputs.all_changed_files }}
steps:
- uses: actions/checkout@v5
- name: Get changed files
id: changed-files
uses: tj-actions/changed-files@v47
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/mdogan/homebrew-zulu/actions/runs/18127831550

The action tj-actions/changed-files@v47 is not allowed in mdogan/homebrew-zulu because all actions must be from a repository owned by mdogan, created by GitHub, verified in the GitHub Marketplace, or match one of the patterns: peter-evans/create-pull-request@, tibdex/github-app-token@.

This can't work for now due to GitHub's limitations.

Copy link
Contributor Author

@Goooler Goooler Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read some problems about tj-actions/changed-files action, that's why I'm hesitating to allow it.

Copy link
Contributor Author

@Goooler Goooler Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well, from my observations. And I noticed there are other solutions like the Homebrew official used, but they are too complex!

Copy link
Contributor Author

@Goooler Goooler Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the auto-merge in Goooler#93.

FYI, I added a related PR to my repo. Goooler/homebrew-repo#61

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if we want to land something like #50, this is useful.

@Goooler Goooler changed the title Support auto-merge for Cask update PRs Support auto-merge for Cask updates Sep 30, 2025
@Goooler
Copy link
Contributor Author

Goooler commented Oct 23, 2025

This should be useful for the PRs like #94.

@Goooler Goooler force-pushed the master branch 5 times, most recently from fbf82be to 4e37cab Compare December 29, 2025 10:01
@Goooler Goooler force-pushed the master branch 2 times, most recently from 8ba4394 to 4495e9c Compare January 4, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants