fix: stop camera after stop publishing video track(windows).

[cloudwebrtc]

close #355

Summary by CodeRabbit

• Bug Fixes
  • Modified track mute handling for platform-specific scenarios. Removed Windows-specific condition; behavior now applies exclusively to Firefox on web browsers.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The skipStopForTrackMute function in lib/src/support/platform.dart has been simplified by removing the Windows-specific condition. The function now returns true only for web platforms when the browser is Firefox, rather than also applying to Windows platforms.

Changes

Cohort / File(s)	Summary
Platform utility fix lib/src/support/platform.dart	Simplified skipStopForTrackMute logic by removing the Windows platform condition. Function now applies track mute skip only to Firefox browsers on web, enabling proper camera shutdown on Windows.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A Windows woe, now fixed with care,
The camera stops, it's only fair!
Firefox on web gets special grace,
While Windows reclaims its proper place. ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The code change removes Windows-specific logic from skipStopForTrackMute, contradicting the PR objective to fix camera stopping behavior specifically for Windows.	Clarify how removing Windows-specific conditions addresses issue #355 which specifically reports camera not turning off on Windows, or revise changes to properly implement Windows camera shutdown.
Out of Scope Changes check	⚠️ Warning	The change modifies skipStopForTrackMute to remove Windows-specific logic and keep only Firefox web platform logic, which appears unrelated to the stated objective of stopping the camera on Windows.	The change should either add Windows-specific camera shutdown logic or provide documentation explaining how this modification fixes the Windows camera issue.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title states 'fix: stop camera after stop publishing video track(windows)' which directly addresses the primary objective to ensure camera is turned off when a video track is stopped on Windows.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70d4d1f and d36a60f.

📒 Files selected for processing (1)

• lib/src/support/platform.dart

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: Build for Flutter Web WASM
• GitHub Check: Build for Flutter Web
• GitHub Check: Build for Flutter macOS
• GitHub Check: Build for Flutter Linux
• GitHub Check: Build for Flutter iOS
• GitHub Check: Build for Flutter Windows
• GitHub Check: Build for Flutter Android
• GitHub Check: Dart Analyze Check

🔇 Additional comments (1)

lib/src/support/platform.dart (1)

40-42: Verify Windows camera shutoff behavior after this change.

Removing Windows from the skip list should allow stop/replaceTrack to run and turn the camera off. Please confirm on Windows 10/11 that the camera LED turns off after stopping/unpublishing the video track, and that Firefox web still behaves as intended (only toggling track.enabled).

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}