Skip to content

Conversation

@thomaswhyyou
Copy link
Contributor

@thomaswhyyou thomaswhyyou commented Jan 15, 2026

Description

TK

thomaswhyyou and others added 6 commits January 15, 2026 16:37
Add the required ineligibleGuides property to all StoreState mock
objects in guide.test.ts to fix type errors after StoreState update.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@linear
Copy link

linear bot commented Jan 15, 2026

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2026

⚠️ No Changeset found

Latest commit: 0f2e854

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Jan 15, 2026 10:38pm
javascript-nextjs-example Ready Ready Preview, Comment Jan 15, 2026 10:38pm
javascript-slack-connect-example Ready Ready Preview, Comment Jan 15, 2026 10:38pm
javascript-slack-kit-example Ready Ready Preview, Comment Jan 15, 2026 10:38pm

Review with Vercel Agent

Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 29.12621% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.62%. Comparing base (4bc310c) to head (0f2e854).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/modules/guide/components/Toolbar/KnockButton.tsx 10.00% 36 Missing ⚠️
.../react/src/modules/guide/components/Toolbar/V2.tsx 23.07% 30 Missing ⚠️
...src/modules/guide/providers/KnockGuideProvider.tsx 25.00% 6 Missing ⚠️
.../react/src/modules/guide/components/Toolbar/V1.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
- Coverage   67.84%   67.62%   -0.23%     
==========================================
  Files         190      193       +3     
  Lines        7934     7993      +59     
  Branches     1041     1040       -1     
==========================================
+ Hits         5383     5405      +22     
- Misses       2526     2563      +37     
  Partials       25       25              
Files with missing lines Coverage Δ
packages/client/src/clients/guide/client.ts 88.82% <100.00%> (+0.09%) ⬆️
packages/client/src/clients/guide/types.ts 100.00% <ø> (ø)
packages/react/src/index.ts 100.00% <ø> (ø)
...ct/src/modules/guide/components/Toolbar/helpers.ts 100.00% <100.00%> (ø)
...eact/src/modules/guide/components/Toolbar/index.ts 100.00% <100.00%> (ø)
...ckages/react/src/modules/guide/components/index.ts 100.00% <100.00%> (ø)
packages/react/src/modules/guide/index.ts 100.00% <ø> (ø)
.../react/src/modules/guide/components/Toolbar/V1.tsx 95.94% <75.00%> (ø)
...src/modules/guide/providers/KnockGuideProvider.tsx 26.66% <25.00%> (-18.79%) ⬇️
.../react/src/modules/guide/components/Toolbar/V2.tsx 23.07% <23.07%> (ø)
... and 1 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants