fix: check win properties in browser code paths for react native #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: bb918d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thomaswhyyou
changed the title
thomaswhyyou
force-pushed
the
thomas-kno-11231-sdk-user-issues-with-type-errors-from-accessing-location
branch
from
6d9789a to
bb918d6
Compare
connorlindsey
approved these changes
Jan 15, 2026
thomaswhyyou
deleted the
thomas-kno-11231-sdk-user-issues-with-type-errors-from-accessing-location
branch
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
=======================================
Coverage 67.84% 67.84%
=======================================
Files 190 190
Lines 7934 7934
Branches 1041 1041
=======================================
Hits 5383 5383
Misses 2526 2526
Partials 25 25
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to address the issue raised here, where user is running into type errors in places accessing window properties in a react naive project.
We already check for the presence of the
windowobject in code paths meant for browser environment. However it seems that in React Native environments it's possible for window may be polyfilled and present but its properties are undefined (e.g. window.location). So in this PR we extend some of the if checks to cover the window properties we are accessing, in addition to the presence of window itself.