UserRepositoryを試しにEntity APIで実装してみたがダメだった件 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entity API doesn't provide a way to get generated auto increment key when inserting record. So it's impossible to reproduce the same logic as SQL DSL.
keyskey
commented
Dec 29, 2021
|
|
||
| @Repository | ||
| class UsersRepositoryImpl(val database: Database): UsersRepository { | ||
| // insert時に生成されたidを取得する手段がない |
Owner
Author
There was a problem hiding this comment.
これが致命的だった。やはりAuto incrementなIDを振る場合Entity APIは使えない。UUIDを使うのであればアリかも。
keyskey
commented
Dec 29, 2021
|
|
||
| return user.copy(id = id) | ||
| val userDao = buildDao(user) | ||
| users().add(userDao) |
Owner
Author
There was a problem hiding this comment.
addメソッドの返り値はinsert文のaffected rowの数。そんなん要らんのよ 😇
keyskey
commented
Dec 29, 2021
| val userDao = buildDao(user) | ||
| users().add(userDao) | ||
|
|
||
| return user |
Owner
Author
There was a problem hiding this comment.
ID取ってこれない以上他にユニークなキーがないので検索して引っ張ってくることもできない。とりあえず元のエンティティ返してるけどID = 0が入ってるのでこの返り値は使えない。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと