fix: ARM64 build fails due to x86-only CRC32 intrinsics #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __attribute__((__target__("crc32"))) and _mm_crc32_u8 intrinsics
are x86-specific but were only guarded by #if (CLANG || GCC), causing
ARM64 builds to fail.
Changes:
- Add x86 guard to target("crc32") attribute
- Add #if (x86) guard around _mm_crc32_u8 with software fallback
Owner
|
Thanks for catching the bug, this is incredibly helpful :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on
aarch64-unknown-linux-gnufails with:The
#if (CLANG || GCC)guard should also check forx86sincetarget("crc32")and_mm_crc32_u8are x86-only.Fixed by changing to
#if (x86 && (CLANG || GCC))and adding a software fallback incrc32_hwfor non-x86.