Refactor: DirectionalLightShadowRenderer reduce object allocations #2513
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaRnMcDonuts
approved these changes
Jun 24, 2025
| /** | ||
| * Creates a DirectionalLight shadow renderer. More info on the technique at <a | ||
| * href="https://developer.nvidia.com/gpugems/GPUGems3/gpugems3_ch10.html">https://developer.nvidia.com/gpugems/GPUGems3/gpugems3_ch10.html</a> | ||
| * Creates a DirectionalLight shadow renderer. This renderer implements the |
Member
There was a problem hiding this comment.
Why remove the link? Still seems to work
Member
There was a problem hiding this comment.
Ah, I see, you've moved it to the top. Makes sense
jme3-core/src/main/java/com/jme3/shadow/DirectionalLightShadowRenderer.java
Show resolved
Hide resolved
codex128
added
the
Refactoring and Cleanup
riccardobl
added
defect
riccardobl
approved these changes
Jan 13, 2026
Member
riccardobl
left a comment
riccardobl
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me.
I undid some formatting and documentation changes to keep this PR focused on the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
DirectionalLightShadowRendererclass to improve code clarity, efficiency, and shadow rendering quality:splits,splitsArray, and reusable vectors.finalfor reusable arrays and temporary vectors to reduce allocations.tempVecreusable vector.These changes do not modify functionality but make the codebase easier to maintain and extend, while also promoting efficient memory usage and clearer intent in shadow rendering logic.