#2460: Fix getBoolean(GLExt.GL_FRAMEBUFFER_SRGB_CAPABLE_EXT) causes error 1280 (invalid enum) #2461
+19
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
GL_FRAMEBUFFER_SRGB_CAPABLE_EXT is actually queryable via glGetBooleanv, but it is provided by the EXT_framebuffer_sRGB extension. I suspect that some drivers that provided opengl3+ capabilities, do not implement a fallback for this extension. |
riccardobl
requested changes
Jan 14, 2026
Member
riccardobl
left a comment
riccardobl
left a comment
There was a problem hiding this comment.
Since this check is only used for debugging purposes and, as noted, it is not reliable across different platforms, i am ok with removing it.
But this PR needs to be cleaned from the unrelated formatting and logging changes, can you do that?
Thanks
jme3-core/src/main/java/com/jme3/renderer/opengl/GLRenderer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GL_FRAMEBUFFER_SRGB_CAPABLE_EXTis likely not a queryable state viaglGetBooleanv. It's a capability flag for configuring framebuffers, not for querying the global sRGB state. It's good that it's commented out.This PR should fix #1996