Skip to content

fix(ENGKOW-2781): gor support versioning of dictionaries #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gmagnu merged 22 commits into from
Jan 12, 2026
Merged

fix(ENGKOW-2781): gor support versioning of dictionaries #93

gmagnu merged 22 commits into from
Jan 12, 2026

Conversation

@gmagnu
Copy link
Contributor

@gmagnu gmagnu commented Jan 12, 2026 •
edited
Loading

  • Changed the default path created for managed files
    1. Add extra folder so we don't get too many files per folder/key.
    2. Use version number instead of random string, to make thins unique. The calls to get the filename needed to be idempotent as the method is possibly called multiple times for each file.
  • Fixed security context issue for when getting managed file location.

gmagnu added 21 commits December 17, 2025 10:31
@gmagnu
fat(ENGKNOW-2781): Minor tweaks to the MDR error handling.
7ee3e25
@gmagnu
fat(ENGKNOW-2781): Fix minor issue with Exec.
40e62eb
@gmagnu
fat(ENGKNOW-2781): Changes to make -link an pgor/paralle work correctly.
95bb59e
@gmagnu
fat(ENGKNOW-2781): Minor refactoring. Cache temp file name for FileTa…
66af801 
…ble.
@gmagnu
Merge branch 'main' of github.com:gorpipe/gor into ENGKNOW-2781-gor-s…
f4469d5 
…upport-versioning-of-dictionaries

# Conflicts:
#	gortools/src/main/scala/gorsat/Analysis/ForkWrite.scala
#	gortools/src/main/scala/gorsat/InputSources/Exec.scala
#	model/src/main/java/org/gorpipe/gor/driver/linkfile/LinkFile.java
#	model/src/main/java/org/gorpipe/gor/driver/linkfile/LinkFileMeta.java
#	model/src/test/java/org/gorpipe/gor/driver/linkfile/LinkFileTest.java
@gmagnu
Merge branch 'main' of github.com:gorpipe/gor into ENGKNOW-2781-gor-s…
effc779 
…upport-versioning-of-dictionaries
@gmagnu
feat(ENGKNOW-2781): Update dict link file support.
9cefa58
@gmagnu
Merge branch 'main' of github.com:gorpipe/gor into ENGKNOW-2781-gor-s…
16a2110 
…upport-versioning-of-dictionaries
@gmagnu
fix(ENGKNOW-2781): Fix invalid sec context.
691a108
@gmagnu
fix(ENGKNOW-2781): Fix invalid sec context.
698846d
@gmagnu
fix(ENGKNOW-2781): Fix invalid sec context.
6a5b49b
@gmagnu
fix(ENGKNOW-2781): Fix invalid sec context.
3bca7fe
@gmagnu
fix(ENGKNOW-2781): Fix invalid sec context.
0ff2a7a
@gmagnu
fix(ENGKNOW-2781): Tweeking link cache paths.
cd8b1d4
@gmagnu
fix(ENGKNOW-2781): Tweeking link cache paths.
5296f58
@gmagnu
fix(ENGKNOW-2781): Tweeking link cache paths.
a0e21dd
@gmagnu
fix(ENGKNOW-2781): Tweeking link cache paths.
e21624c
@gmagnu
fix(ENGKNOW-2781): Tweeking link cache paths.
2531999
@gmagnu
fix(ENGKNOW-2781): Tweeking link cache paths.
93fd062
@gmagnu
fix(ENGKNOW-2781): Tweeking link cache paths.
3fe36a7
@gmagnu
fix(ENGKNOW-2781): Tweeking link cache paths.
6be2d8d
lakshmiprabhaseker
lakshmiprabhaseker approved these changes Jan 12, 2026
View reviewed changes
Copy link

@lakshmiprabhaseker lakshmiprabhaseker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmagnu
Merge branch 'main' of github.com:gorpipe/gor into ENGKNOW-2781-gor-s…
1e2bb36 
…upport-versioning-of-dictionaries

# Conflicts:
#	gortools/src/main/scala/gorsat/Commands/Write.scala
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

Junit Tests - Summary

4 379 tests  ±0   4 207 ✅ ±0   11m 42s ⏱️ + 1m 18s
  460 suites +1     172 💤 ±0 
  460 files   +1       0 ❌ ±0 

Results for commit 1e2bb36. ± Comparison against base commit 9628d16.

@gmagnu gmagnu merged commit 501e346 into main Jan 12, 2026
11 checks passed
@gmagnu gmagnu deleted the ENGKNOW-2781-gor-support-versioning-of-dictionaries branch January 12, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lakshmiprabhaseker lakshmiprabhaseker lakshmiprabhaseker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gmagnu @lakshmiprabhaseker