Remove SockJS CDN reference from Web UI templates #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the external sockjs-client CDN script tag from the source index template and the built dist index. SockJS remains bundled via the vendor bundle so the UI works fully offline when dist assets are served locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the external SockJS CDN script tag from the Web UI templates so offline environments don’t depend on the internet. SockJS is already bundled via sockjs-client in the vendor bundle (imported in [vendor.ts]), so the UI loads it from the local vendor.*.js.
With this change, a machine with no internet access will still work as long as the local dist/ assets are served.
The Web UI server serves local dist assets directly.
It sets [STATIC_FILES_ROOT] to the web_gui/dist directory and registers a static file route for /css/, /js/, /img/*, and /service-worker.js, plus the index template from the same directory. See [web_gui_server.py:20-123].
This should resolve issue #1174