Optimization to Skip this entire family #2105
Open
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
urmez
changed the title
Member
|
can you add tests please? and run the formatter. |
LebedevRI
reviewed
Jan 19, 2026
| // Check if the filter spec starts with the family name | ||
| // or if the family name appears as a substring in the spec | ||
| family_could_match = spec.find(family->name_) != std::string::npos || | ||
| spec == "." || |
Collaborator
There was a problem hiding this comment.
The . special case should probably be checked first.
LebedevRI
reviewed
Jan 19, 2026
|
|
||
| // Optimization: Quick check if family name could match the filter | ||
| // before iterating through all args combinations | ||
| bool family_name_disabled = family->name_.rfind(kDisabledPrefix, 0) == 0; |
Collaborator
There was a problem hiding this comment.
Why rfind() though, instead of find()?
That being said i think it might make sense to define a helper function string_has_prefix() for this...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.