Skip to content

Rust: Add barrier for split_off #21153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geoffw0 wants to merge 3 commits into
base: main
Choose a base branch
from
+133 −117
Open

Rust: Add barrier for split_off #21153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7658ebb
Rust: Add spurious test case for rust/uncontrolled-allocation-size.
geoffw0 Jan 9, 2026
479c58b
Rust: Add a barrier.
geoffw0 Jan 9, 2026
a78756f
Merge branch 'main' into splitoff
geoffw0 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions rust/ql/lib/codeql/rust/security/UncontrolledAllocationSizeExtensions.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,17 @@
branch = false
)
}

/**
* A barrier for uncontrolled allocation size flow into particular functions.
*/
private class ModelledBarrier extends Barrier {

Check warning

Code scanning / CodeQL

Misspelling Warning

This class name contains the non-US spelling 'modelled', which should instead be 'modeled'.
Copy link
Contributor

@paldepind paldepind Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Copilot is right about this one.

ModelledBarrier() {
exists(MethodCall c |
c.getStaticTarget().getCanonicalPath() =
["<alloc::string::String>::split_off", "<alloc::vec::Vec>::split_off"] and
this.asExpr() = c.getAnArgument()
)
}
}
}
Loading