Skip to content

Conversation

@mike-sul
Copy link
Contributor

@mike-sul mike-sul commented Jan 7, 2026

  • Enable CI to authenticate with arbitrary container registries
  • Provide example for configuring CI with ghcr.io
  • Update factory configuration to support third-party registries
  • Explain device configuration for pulling images from registries

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.
You may delete items that are not relevant to your contribution.
Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck, and add redirects for any moved or deleted pages.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

- Enable CI to authenticate with arbitrary container registries
- Provide example for configuring CI with `ghcr.io`
- Update factory configuration to support third-party registries
- Explain device configuration for pulling images from registries

Signed-off-by: Mike Sul <mike.sul@foundries.io>
Copy link
Member

@doanac doanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mike-sul mike-sul marked this pull request as ready for review January 9, 2026 08:03
@mike-sul mike-sul requested a review from kprosise January 9, 2026 08:03
Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mike-sul mike-sul merged commit 5aff165 into main Jan 12, 2026
2 of 3 checks passed
@mike-sul mike-sul deleted the 3rdparty-registries-support branch January 12, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants