-
Notifications
You must be signed in to change notification settings - Fork 357
Remove TData #4771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mpolson64
wants to merge
1
commit into
facebook:main
Choose a base branch
from
mpolson64:export-D90596942
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove TData #4771
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpolson64 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90596942. |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Jan 15, 2026
Summary: TData was necesssary whern we had multiple different Data classes, but recent developments have made this no longer needed Differential Revision: D90596942
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4771 +/- ##
==========================================
- Coverage 96.73% 96.72% -0.01%
==========================================
Files 585 585
Lines 61196 61195 -1
==========================================
- Hits 59195 59192 -3
- Misses 2001 2003 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Jan 15, 2026
Summary: TData was necesssary whern we had multiple different Data classes, but recent developments have made this no longer needed Differential Revision: D90596942
Summary: TData was necesssary whern we had multiple different Data classes, but recent developments have made this no longer needed Reviewed By: esantorella, saitcakmak Differential Revision: D90596942 Privacy Context Container: L1413903
a9478d3 to
ea94eb7
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Jan 16, 2026
Summary: TData was necesssary whern we had multiple different Data classes, but recent developments have made this no longer needed Reviewed By: esantorella, saitcakmak Differential Revision: D90596942 Privacy Context Container: L1413903
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Jan 16, 2026
Summary: TData was necesssary whern we had multiple different Data classes, but recent developments have made this no longer needed Reviewed By: esantorella, saitcakmak Differential Revision: D90596942 Privacy Context Container: L1413903
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Jan 16, 2026
Summary: TData was necesssary whern we had multiple different Data classes, but recent developments have made this no longer needed Reviewed By: esantorella, saitcakmak Differential Revision: D90596942 Privacy Context Container: L1413903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: TData was necesssary whern we had multiple different Data classes, but recent developments have made this no longer needed
Differential Revision: D90596942