Skip to content

Conversation

@marcosbento
Copy link
Collaborator

@marcosbento marcosbento commented Jan 18, 2026

Description

These changes remove restriction to local externs, thus allowing the declaration of externs that declare nodes/attributes to a suite that is locally available.

For example, the following will be allowed (where it was previously not accepted):

# notice that the /user suite is defined "partially". This means that only the branch
# /user/experiment2 is available locally, while the user obviously expects to also have
# a /user/experiment1 available on the server.

extern /user/experiment1/path/to/specific/node
suite user
  family experiment2
    family node
      trigger /user/experiment1/path/to/specific/node == complete
    endfamily
  endfamily
endsuite

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-264

This effectively allows to reference local nodes that don't actually
exist. This is useful when a user generates only part of the suite,
to update it but still has triggers for other nodes in the same
suite.

Re ECFLOW-2033
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.25%. Comparing base (d2b2d45) to head (05617ff).

Files with missing lines Patch % Lines
libs/test/foolproof/TestFoolproof.NodeExtern.cpp 95.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #264      +/-   ##
===========================================
- Coverage    49.29%   49.25%   -0.04%     
===========================================
  Files         1230     1231       +1     
  Lines        96924    96964      +40     
  Branches     14858    14857       -1     
===========================================
- Hits         47778    47762      -16     
- Misses       49146    49202      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcosbento marcosbento force-pushed the feature/remove_restriction_to_local_externs branch from 9c83e29 to 05617ff Compare January 19, 2026 10:31
@marcosbento marcosbento merged commit 9b860c1 into develop Jan 19, 2026
134 checks passed
@marcosbento marcosbento deleted the feature/remove_restriction_to_local_externs branch January 19, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants