Skip to content

Conversation

@NEOatNHNG
Copy link
Contributor

@NEOatNHNG NEOatNHNG commented Jan 9, 2026

Don't fetch starpls via bazel and use the one installed on the system or devcontainer instead.

Also clean up and fix some other vscode settings.

Related ticket

Addresses eclipse-score/tooling#79 (bugfix ticket)

Also cleaned up vscode configuration.
It is already present in the devcontainer.

Addresses eclipse-score/tooling#79
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 1cdcf39e-349a-4816-a6b7-5272faf4c77b
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (82 packages loaded, 9 targets configured)

Analyzing: target //:license-check (100 packages loaded, 34 targets configured)

Analyzing: target //:license-check (149 packages loaded, 2604 targets configured)

Analyzing: target //:license-check (155 packages loaded, 4974 targets configured)

INFO: Analyzed target //:license-check (158 packages loaded, 6990 targets configured).
[1 / 1] no actions running
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 2 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 15.235s, Critical Path: 0.28s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

The created documentation from the pull request is available at: docu-html

@NEOatNHNG NEOatNHNG marked this pull request as ready for review January 9, 2026 16:31
@NEOatNHNG NEOatNHNG requested review from Aymen-Soussi-01 and nicu1989 and removed request for nicu1989 January 12, 2026 09:20
// BasedPyright for python various type checking improvements and pylance features
"detachhead.basedpyright",
// Bazel BUILD integration
"bazelbuild.vscode-bazel",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incompatible with docs-as-code preview, that's why we did not include it. No idea if people use that preview feature or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean with "docs-as-code preview"? I just tried to start bazel run :live_preview in a terminal and that still works as intended, as far as I can tell, even though that extension is installed.
At least for module development I guess I rather have a bazel integration than a live preview for my docs as code. Different story on document-heavy repos like eclipse-score/score of course.

99
],

// Exclude build, temp and cache folders
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like this file (actually both) will be much harder to read without the newlines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is auto-format of the file in vscode. I mean we can also have some explicit non-default formatting but then we should create a formatting setting for JSON. I personally don't want to manually format files.

Comment on lines +57 to +59
"files.insertFinalNewline": false,
"files.trimFinalNewlines": false,
"files.trimTrailingWhitespace": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are patch files, so they shouldn't be modified automatically in any way. And whitespace matters in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Draft

Development

Successfully merging this pull request may close these issues.

2 participants