-
Notifications
You must be signed in to change notification settings - Fork 11
Don't fetch starpls_server via bazel and fix vscode settings #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Don't fetch starpls_server via bazel and fix vscode settings #39
Conversation
Also cleaned up vscode configuration.
It is already present in the devcontainer. Addresses eclipse-score/tooling#79
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
| // BasedPyright for python various type checking improvements and pylance features | ||
| "detachhead.basedpyright", | ||
| // Bazel BUILD integration | ||
| "bazelbuild.vscode-bazel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incompatible with docs-as-code preview, that's why we did not include it. No idea if people use that preview feature or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean with "docs-as-code preview"? I just tried to start bazel run :live_preview in a terminal and that still works as intended, as far as I can tell, even though that extension is installed.
At least for module development I guess I rather have a bazel integration than a live preview for my docs as code. Different story on document-heavy repos like eclipse-score/score of course.
| 99 | ||
| ], | ||
|
|
||
| // Exclude build, temp and cache folders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like this file (actually both) will be much harder to read without the newlines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is auto-format of the file in vscode. I mean we can also have some explicit non-default formatting but then we should create a formatting setting for JSON. I personally don't want to manually format files.
| "files.insertFinalNewline": false, | ||
| "files.trimFinalNewlines": false, | ||
| "files.trimTrailingWhitespace": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are patch files, so they shouldn't be modified automatically in any way. And whitespace matters in there.
Don't fetch starpls via bazel and use the one installed on the system or devcontainer instead.
Also clean up and fix some other vscode settings.
Related ticket
Addresses eclipse-score/tooling#79 (bugfix ticket)