Implement external applications authentication flow #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add /api/auth/authorize and /api/auth/token endpoints to enable OAuth2 authorization code flow for desktop applications and external clients. - Add oauth2Server config with typed client definitions - Add oauthCodes MongoDB collection with 5-minute TTL - Support configurable redirect URIs per client - Generate access_token and id_token_ex for authenticated users
- GET /api/auth/apps/authorize now redirects to login UI with step=authorizeApp - Added POST /api/auth/apps/authorize endpoint that generates the auth code after user confirms - Added authorizeApp step in login.vue with confirmation message and buttons - User must click 'Authorize' to generate code, can click 'Cancel' to deny access - Added i18n translations for authorization UI (fr/en)
- Show 'You can close this tab' message after redirecting to app - Attempt window.close() for better UX - Improve spacing between logo, card and maildev link - Fix icon syntax to use mdiCheckCircle variable
Window close cannot reliably detect if user confirmed custom protocol URLs (my-app://), and window.close() only works for windows opened via window.open(). Users will now see the success message and close manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented a simplified authentication flow for external applications (e.g., desktop apps) to authenticate users via the
simple-directoryservice.Changes
GET /api/auth/apps/authorize: Validates application configuration and redirects to the UI for user confirmation.POST /api/auth/apps/authorize: Generates a short-lived authorization code after user confirmation.POST /api/auth/apps/login: Exchanges the authorization code for session cookies.authorizeAppstep in the login page for user confirmation.appRedirectedsuccess state with a message and automatic window closing attempt.applicationssupport in global and site-level configurations (ID, Name, Redirect URIs).test-it/external-apps-authorization.ts.