Skip to content

Enforce PMD MethodNamingConventions: rename internals and deprecate legacy public APIs #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shai-almog merged 2 commits into from
Jan 17, 2026
Merged

Enforce PMD MethodNamingConventions: rename internals and deprecate legacy public APIs #4430

shai-almog merged 2 commits into from
Jan 17, 2026
+361 −190

Conversation

@shai-almog
Copy link
Collaborator

@shai-almog shai-almog commented Jan 17, 2026

Motivation

  • Remove existing PMD MethodNamingConventions violations by moving non-conforming names to acceptable camelCase identifiers while preserving public API compatibility.
  • Public and protected APIs could not be renamed, so existing legacy-named public methods must remain available but be deprecated and excluded from PMD failures.
  • Ensure PMD failures for method naming are enforced in the PR quality gate going forward.

Description

  • Deprecated legacy public accessor methods that used underscores (Facebook models Album, Photo, User) and introduced camelCase replacements that return the same values, with the legacy methods annotated @Deprecated and @SuppressWarnings("PMD.MethodNamingConventions") and forwarding to the new methods.
  • Renamed many internal helper methods to camelCase across gzip and inflate code (CRC32, InfBlocks, InfCodes, InfTree, Inflate, Deflate, ZStream, JZlib) and updated their call sites to use the new names; for JZlib the old *_combine methods were kept as deprecated wrappers delegating to *Combine methods.
  • Renamed internal processing helpers and utilities from underscore-style to camelCase in processing package (AbstractEvaluator, ContainsEvaluator, HashtableContent, IndexEvaluator, Result, TextEvaluator, XMLContent) and updated references accordingly.
  • Added deprecated camel/compat wrappers and small API fixes in UI code (ComponentSelector $ aliases now deprecated and forward to select* variants, Transform.IDENTITY() deprecated in favor of identity(), CodenameOneMiGComponentWrapper legacy 1_4 methods deprecated and new 14 variants added), renamed path/geometry helper (GeneralPath) and math helper names in MathUtil to camelCase.
  • Updated the quality report generator to treat PMD rule MethodNamingConventions as a forbidden PMD rule so future violations will fail the PR quality check (.github/scripts/generate-quality-report.py).

Testing

  • No automated tests were run as part of this change (no CI or mvn invocation was executed).

Codex Task

@shai-almog
Copy link
Collaborator Author

shai-almog commented Jan 17, 2026 •
edited
Loading

Compared 30 screenshots: 30 matched.

Native Android coverage

  • 📊 Line coverage: 24.71% (2648/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 24.20% (12229/50528), branch 15.18% (709/4672), complexity 17.47% (741/4241), method 32.75% (596/1820), class 33.99% (103/303)
    • Lowest covered classes
      • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
      • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

  • 📊 Line coverage: 24.71% (2648/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 24.20% (12229/50528), branch 15.18% (709/4672), complexity 17.47% (741/4241), method 32.75% (596/1820), class 33.99% (103/303)
    • Lowest covered classes
      • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
      • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

@shai-almog
Copy link
Collaborator Author

shai-almog commented Jan 17, 2026 •
edited
Loading

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

  • BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    BrowserComponent
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

  • graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-arc
    Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

  • graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-gradient
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

  • graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

    graphics-draw-round-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

  • graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-string
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
    Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

  • graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-string-decorated
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

  • kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    kotlin
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

  • VM Translation Time: 336 seconds
  • Compilation Time: 113 seconds

Detailed Performance Metrics

Metric Duration
Build Time Statistics
Setup & Unzip 34629 ms
Extract Extensions 19 ms
Google Services Setup 3 ms
Scan Classes 580 ms
Extract Libs 1429 ms
Inject Build Hints 37 ms
Generate Unit Tests 2 ms
Generate Stubs 1232 ms
Compile Stubs 2655 ms
Generate Icons 1221 ms
Prepare ParparVM 180 ms
ParparVM Execution 189189 ms
Post-VM Setup 102 ms
CocoaPods 4620 ms
Finalize 46 ms
Total Time 235945 msMaven Overhead : 101000 ms
CocoaPods Install (Script) 1000 ms
Simulator Boot (Run) 71000 ms
App Install 12000 ms
App Launch 8000 ms
Test Execution 139000 ms

@github-actions
Copy link

github-actions bot commented Jan 17, 2026

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Generated automatically by the PR CI workflow.

@shai-almog shai-almog merged commit 5dab9fb into master Jan 17, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shai-almog